This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-text.git

commit b488bfc2d4dc2c02e6cb63b0bedb83e4463bf363
Author: Gary D. Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Jul 19 13:44:01 2025 -0400

    Fix PMD UnnecessaryFullyQualifiedName in StrSubstitutor
---
 src/changes/changes.xml                                   | 1 +
 src/main/java/org/apache/commons/text/StrSubstitutor.java | 3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 87e599fb..45df8004 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -52,6 +52,7 @@ The <action> type attribute can be add,update,fix,remove.
     <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD 
UnnecessaryFullyQualifiedName in PropertiesStringLookup.</action>
     <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD 
UnnecessaryFullyQualifiedName in JavaPlatformStringLookup.</action>
     <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD 
UnnecessaryFullyQualifiedName in StringSubstitutor.</action>
+    <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD 
UnnecessaryFullyQualifiedName in StrSubstitutor.</action>
     <!-- ADD -->
     <action type="add" dev="ggregory" due-to="Gary Gregory">Interface 
StringLookup now extends UnaryOperator&lt;String&gt;.</action>
     <action type="add" dev="ggregory" due-to="Gary Gregory">Interface 
TextRandomProvider extends IntUnaryOperator.</action>
diff --git a/src/main/java/org/apache/commons/text/StrSubstitutor.java 
b/src/main/java/org/apache/commons/text/StrSubstitutor.java
index 88570e85..aa839710 100644
--- a/src/main/java/org/apache/commons/text/StrSubstitutor.java
+++ b/src/main/java/org/apache/commons/text/StrSubstitutor.java
@@ -191,8 +191,7 @@ public class StrSubstitutor {
         if (valueProperties == null) {
             return source.toString();
         }
-        return StrSubstitutor.replace(source,
-                
valueProperties.stringPropertyNames().stream().collect(Collectors.toMap(Function.identity(),
 valueProperties::getProperty)));
+        return replace(source, 
valueProperties.stringPropertyNames().stream().collect(Collectors.toMap(Function.identity(),
 valueProperties::getProperty)));
     }
 
     /**

Reply via email to