This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git

commit 9739f54ea8a4257cdf5f26fa54ab6be1e8aa6730
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Fri Feb 28 18:31:46 2025 -0500

    Add Checkstyle LeftCurly
---
 src/conf/checkstyle.xml                                               | 1 +
 .../java/org/apache/commons/net/examples/ftp/FTPClientExample.java    | 4 ++--
 .../java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.java | 4 ++--
 src/main/java/org/apache/commons/net/telnet/Telnet.java               | 4 ++--
 4 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/conf/checkstyle.xml b/src/conf/checkstyle.xml
index 7b40548f..b1c594d5 100644
--- a/src/conf/checkstyle.xml
+++ b/src/conf/checkstyle.xml
@@ -80,6 +80,7 @@ limitations under the License.
       <property name="accessModifiers" value="public"/>
       <property name="allowMissingParamTags" value="true"/>
     </module>
+    <module name="LeftCurly" />
     <module name="ModifierOrder"/>
     <module name="NeedBraces"/>
     <module name="ParenPad"/>
diff --git 
a/src/main/java/org/apache/commons/net/examples/ftp/FTPClientExample.java 
b/src/main/java/org/apache/commons/net/examples/ftp/FTPClientExample.java
index 170d08bc..f037453a 100644
--- a/src/main/java/org/apache/commons/net/examples/ftp/FTPClientExample.java
+++ b/src/main/java/org/apache/commons/net/examples/ftp/FTPClientExample.java
@@ -233,8 +233,8 @@ public final class FTPClientExample {
         if (user != null) {
             minParams -= 2;
         }
-        if (remain < minParams) // server, user, pass, remote, local [protocol]
-        {
+        if (remain < minParams) {
+            // server, user, pass, remote, local [protocol]
             if (args.length > 0) {
                 System.err.println("Actual Parameters: " + 
Arrays.toString(args));
             }
diff --git 
a/src/main/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.java 
b/src/main/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.java
index 1776dc08..55d854a2 100644
--- a/src/main/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.java
+++ b/src/main/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.java
@@ -129,8 +129,8 @@ public class NetwareFTPEntryParser extends 
ConfigurableFTPFileEntryParserImpl {
             // is it a DIR or a file
             if (dirString.trim().equals("d")) {
                 f.setType(FTPFile.DIRECTORY_TYPE);
-            } else // Should be "-"
-            {
+            } else {
+                // Should be "-"
                 f.setType(FTPFile.FILE_TYPE);
             }
 
diff --git a/src/main/java/org/apache/commons/net/telnet/Telnet.java 
b/src/main/java/org/apache/commons/net/telnet/Telnet.java
index 0f0c7c42..5a770005 100644
--- a/src/main/java/org/apache/commons/net/telnet/Telnet.java
+++ b/src/main/java/org/apache/commons/net/telnet/Telnet.java
@@ -930,8 +930,8 @@ class Telnet extends SocketClient {
         final OutputStream spy = spyStream;
         if (spy != null) {
             try {
-                if (ch != '\r') // never write '\r' on its own
-                {
+                // never write '\r' on its own
+                if (ch != '\r') {
                     if (ch == '\n') {
                         spy.write('\r'); // add '\r' before '\n'
                     }

Reply via email to