(commons-net) 06/24: Add Checkstyle "FallThrough"

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git

commit 36baea9ae32eee0fb9f377181e71701967d5d15e
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Fri Feb 28 18:24:18 2025 -0500

    Add Checkstyle "FallThrough"
---
 src/conf/checkstyle.xml                                                 | 1 +
 src/main/java/org/apache/commons/net/io/DotTerminatedMessageWriter.java | 2 +-
 src/main/java/org/apache/commons/net/io/ToNetASCIIInputStream.java      | 2 +-
 src/main/java/org/apache/commons/net/io/ToNetASCIIOutputStream.java     | 2 +-
 src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java      | 2 +-
 .../java/org/apache/commons/net/ftp/parser/UnixFTPEntryParserTest.java  | 2 +-
 6 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/conf/checkstyle.xml b/src/conf/checkstyle.xml
index eb5eaed9..fabe7330 100644
--- a/src/conf/checkstyle.xml
+++ b/src/conf/checkstyle.xml
@@ -66,6 +66,7 @@ limitations under the License.
     <module name="EmptyCatchBlock"></module>
     <module name="EqualsHashCode" />
     <module name="ExplicitInitialization" />
+    <module name="FallThrough" />
     <module name="ImportOrder">
       <property name="option" value="top"/>
       <property name="groups" value="java,javax,org"/>
diff --git 
a/src/main/java/org/apache/commons/net/io/DotTerminatedMessageWriter.java 
b/src/main/java/org/apache/commons/net/io/DotTerminatedMessageWriter.java
index b5fc3f85..7c2d14d5 100644
--- a/src/main/java/org/apache/commons/net/io/DotTerminatedMessageWriter.java
+++ b/src/main/java/org/apache/commons/net/io/DotTerminatedMessageWriter.java
@@ -141,7 +141,7 @@ public final class DotTerminatedMessageWriter extends 
Writer {
                 if (state == LAST_WAS_NL_STATE) {
                     output.write('.');
                 }
-                //$FALL-THROUGH$
+                // falls through$
             default:
                 state = NOTHING_SPECIAL_STATE;
                 output.write(ch);
diff --git a/src/main/java/org/apache/commons/net/io/ToNetASCIIInputStream.java 
b/src/main/java/org/apache/commons/net/io/ToNetASCIIInputStream.java
index 9c069e1e..6cba5a11 100644
--- a/src/main/java/org/apache/commons/net/io/ToNetASCIIInputStream.java
+++ b/src/main/java/org/apache/commons/net/io/ToNetASCIIInputStream.java
@@ -89,7 +89,7 @@ public final class ToNetASCIIInputStream extends 
FilterInputStream {
                 status = LAST_WAS_NL;
                 return '\r';
             }
-            //$FALL-THROUGH$
+            // falls through$
         default:
             status = NOTHING_SPECIAL;
             return ch;
diff --git 
a/src/main/java/org/apache/commons/net/io/ToNetASCIIOutputStream.java 
b/src/main/java/org/apache/commons/net/io/ToNetASCIIOutputStream.java
index c1aaa8d1..99bba90e 100644
--- a/src/main/java/org/apache/commons/net/io/ToNetASCIIOutputStream.java
+++ b/src/main/java/org/apache/commons/net/io/ToNetASCIIOutputStream.java
@@ -83,7 +83,7 @@ public final class ToNetASCIIOutputStream extends 
FilterOutputStream {
             if (!lastWasCR) {
                 out.write('\r');
             }
-            //$FALL-THROUGH$
+            // falls through$
         default:
             lastWasCR = false;
             out.write(ch);
diff --git a/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java 
b/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java
index 88a73148..c217e7de 100644
--- a/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java
+++ b/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java
@@ -305,7 +305,7 @@ final class TelnetInputStream extends BufferedInputStream 
implements Runnable {
 
                 // Handle as normal data by falling through to _STATE_DATA case
 
-                //$FALL-THROUGH$
+                // falls through$
             case STATE_DATA:
                 if (ch == TelnetCommand.IAC) {
                     receiveState = STATE_IAC;
diff --git 
a/src/test/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParserTest.java 
b/src/test/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParserTest.java
index 2dc1da96..7581ed6d 100644
--- 
a/src/test/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParserTest.java
+++ 
b/src/test/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParserTest.java
@@ -104,7 +104,7 @@ public class UnixFTPEntryParserTest extends 
AbstractFTPParseTest {
         case 'b':
         case 'c':
             assertEquals(0, f.getHardLinkCount());
-            //$FALL-THROUGH$ TODO this needs to be fixed if a device type is 
introduced
+            // falls through$ TODO this needs to be fixed if a device type is 
introduced
         case 'f':
         case '-':
             assertEquals("Type of " + test, type, FTPFile.FILE_TYPE);