This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit 833e6704fc6de9c76e6cba4bbdbf26d0da89615b Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Sun Jun 16 18:18:01 2024 -0400 Fix PMD UselessOverridingMethod in org.apache.commons.net.telnet.TelnetClient --- src/changes/changes.xml | 1 + .../org/apache/commons/net/telnet/TelnetClient.java | 17 ----------------- 2 files changed, 1 insertion(+), 17 deletions(-) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 5a1b5c78..7c02d4ee 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -74,6 +74,7 @@ The <action> type attribute can be add,update,fix,remove. <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD UnnecessaryFullyQualifiedName.</action> <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD UnusedFormalParameter.</action> <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD AvoidBranchingStatementAsLastInLoop in org.apache.commons.net.bsd.RCommandClient.</action> + <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD UselessOverridingMethod in org.apache.commons.net.telnet.TelnetClient.</action> <!-- ADD --> <!-- UPDATE --> <action type="update" dev="ggregory" due-to="Gary Gregory, Dependabot">Bump org.apache.commons:commons-parent from 70 to 71 #261.</action> diff --git a/src/main/java/org/apache/commons/net/telnet/TelnetClient.java b/src/main/java/org/apache/commons/net/telnet/TelnetClient.java index e432d48c..61b87476 100644 --- a/src/main/java/org/apache/commons/net/telnet/TelnetClient.java +++ b/src/main/java/org/apache/commons/net/telnet/TelnetClient.java @@ -261,16 +261,6 @@ public class TelnetClient extends Telnet { this.inputListener = listener; } - /** - * Registers a notification handler to which will be sent notifications of received telnet option negotiation commands. - * - * @param notifhand TelnetNotificationHandler to be registered - */ - @Override - public void registerNotifHandler(final TelnetNotificationHandler notifhand) { - super.registerNotifHandler(notifhand); - } - /* Code Section added for supporting spystreams (start) */ /** * Registers an OutputStream for spying what's going on in the TelnetClient session. @@ -394,11 +384,4 @@ public class TelnetClient extends Telnet { this.inputListener = null; } - /** - * Unregisters the current notification handler. - */ - @Override - public void unregisterNotifHandler() { - super.unregisterNotifHandler(); - } }