This is an automated email from the ASF dual-hosted git repository. ggregory pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-net.git
from 7e12be77 Javadoc new 99bb71a6 Javadoc new 833e6704 Fix PMD UselessOverridingMethod in org.apache.commons.net.telnet.TelnetClient new 77cb3c2d Add NOPMD comment for constant. new 93097d06 Javadoc new 6b3a6f5f Javadoc new 30527ab8 Fix PMD UnnecessaryFullyQualifiedName new c5eaef06 Fix PMD UnnecessaryModifier new 628a336a Fix PMD UnnecessaryFullyQualifiedName new 2e7764c5 Fix PMD UnnecessaryModifier new 59e1206d Add NOPMD as a TODO, not trivial new 0baa3569 Add PMD check to default build The 11 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: pom.xml | 20 +++++- src/changes/changes.xml | 2 + src/conf/pmd-ruleset.xml | 81 ++++++++++++++++++++++ .../apache/commons/net/ProtocolCommandSupport.java | 6 ++ .../org/apache/commons/net/bsd/RExecClient.java | 2 +- .../net/examples/cidr/SubnetUtilsExample.java | 2 +- .../commons/net/examples/ftp/FTPClientExample.java | 4 +- .../commons/net/examples/mail/POP3ExportMbox.java | 8 +-- .../apache/commons/net/examples/ntp/NTPClient.java | 4 +- .../net/examples/telnet/TelnetClientExample.java | 4 +- .../commons/net/examples/telnet/WeatherTelnet.java | 4 +- .../apache/commons/net/examples/unix/chargen.java | 2 +- .../apache/commons/net/finger/FingerClient.java | 2 +- src/main/java/org/apache/commons/net/ftp/FTP.java | 4 +- .../java/org/apache/commons/net/ftp/FTPClient.java | 6 +- .../java/org/apache/commons/net/ftp/FTPCmd.java | 2 +- .../java/org/apache/commons/net/ftp/FTPFile.java | 8 ++- .../apache/commons/net/ftp/FTPListParseEngine.java | 2 +- .../org/apache/commons/net/ftp/FTPSClient.java | 2 +- .../commons/net/imap/AuthenticatingIMAPClient.java | 2 +- .../org/apache/commons/net/imap/IMAPClient.java | 2 +- .../org/apache/commons/net/imap/IMAPCommand.java | 2 +- .../org/apache/commons/net/nntp/NNTPClient.java | 8 +-- .../java/org/apache/commons/net/ntp/TimeStamp.java | 6 ++ .../commons/net/pop3/ExtendedPOP3Client.java | 2 +- .../commons/net/smtp/AuthenticatingSMTPClient.java | 2 +- .../org/apache/commons/net/smtp/SMTPClient.java | 2 +- .../commons/net/telnet/EchoOptionHandler.java | 2 +- .../net/telnet/SuppressGAOptionHandler.java | 2 +- .../java/org/apache/commons/net/telnet/Telnet.java | 4 +- .../apache/commons/net/telnet/TelnetClient.java | 33 +++------ .../apache/commons/net/telnet/TelnetCommand.java | 8 +-- .../commons/net/telnet/TelnetInputStream.java | 8 +-- .../net/telnet/TelnetNotificationHandler.java | 2 +- .../apache/commons/net/telnet/TelnetOption.java | 8 +-- .../commons/net/telnet/TelnetOptionHandler.java | 2 +- .../net/telnet/TerminalTypeOptionHandler.java | 2 +- .../net/telnet/WindowSizeOptionHandler.java | 2 +- .../org/apache/commons/net/util/ListenerList.java | 9 ++- .../java/org/apache/commons/net/MockTcpServer.java | 4 +- .../commons/net/daytime/MockDaytimeTCPServer.java | 2 +- .../org/apache/commons/net/examples/MainTest.java | 4 +- .../commons/net/ftp/parser/MLSDComparison.java | 4 +- .../commons/net/io/ToNetASCIIInputStreamTest.java | 2 +- .../net/telnet/TelnetClientFunctionalTest.java | 2 +- .../commons/net/telnet/TelnetClientTest.java | 2 +- .../commons/net/tftp/TFTPServerPathTest.java | 14 ++-- .../java/org/apache/commons/net/tftp/TFTPTest.java | 6 +- 48 files changed, 210 insertions(+), 103 deletions(-) create mode 100644 src/conf/pmd-ruleset.xml