(commons-collections) 07/16: Fix PMD UnnecessaryFullyQualifiedName in StringKeyAnalyzer

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git

commit a68b8ab03ec818cf45cdbbd274e4a1d5d43c5d7d
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Wed May 22 08:38:38 2024 -0400

    Fix PMD UnnecessaryFullyQualifiedName in StringKeyAnalyzer
---
 src/changes/changes.xml                                               | 1 +
 .../apache/commons/collections4/trie/analyzer/StringKeyAnalyzer.java  | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 8062d7467..69812d682 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -38,6 +38,7 @@
      <action type="update" dev="ggregory" due-to="PMD, Gary Gregory">Fix PMD 
UnnecessaryFullyQualifiedName in TransformerUtils.</action>
      <action type="update" dev="ggregory" due-to="PMD, Gary Gregory">Fix PMD 
UnnecessaryFullyQualifiedName in DefaultEquator.</action>
      <action type="update" dev="ggregory" due-to="PMD, Gary Gregory">Fix PMD 
UnnecessaryFullyQualifiedName in AbstractHashedMap.</action>
+     <action type="update" dev="ggregory" due-to="PMD, Gary Gregory">Fix PMD 
UnnecessaryFullyQualifiedName in StringKeyAnalyzer.</action>
      <!-- UPDATE -->
      <action type="update" dev="ggregory" due-to="Dependabot">Bump 
org.apache.commons:commons-parent from 67 to 69 #473.</action>
      <action type="update" dev="ggregory" due-to="Dependabot">Bump tests 
commons-io:commons-io from 2.16.0 to 2.16.1 #475.</action>
diff --git 
a/src/main/java/org/apache/commons/collections4/trie/analyzer/StringKeyAnalyzer.java
 
b/src/main/java/org/apache/commons/collections4/trie/analyzer/StringKeyAnalyzer.java
index 108de75aa..de490f606 100644
--- 
a/src/main/java/org/apache/commons/collections4/trie/analyzer/StringKeyAnalyzer.java
+++ 
b/src/main/java/org/apache/commons/collections4/trie/analyzer/StringKeyAnalyzer.java
@@ -92,11 +92,11 @@ public class StringKeyAnalyzer extends KeyAnalyzer<String> {
 
         // All bits are 0
         if (allNull) {
-            return KeyAnalyzer.NULL_BIT_KEY;
+            return NULL_BIT_KEY;
         }
 
         // Both keys are equal
-        return KeyAnalyzer.EQUAL_BIT_KEY;
+        return EQUAL_BIT_KEY;
     }
 
     @Override