This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git

commit fe4fff6ab040a654611c2996357d28ef078b79b1
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Wed May 22 08:35:00 2024 -0400

    Fix PMD UnnecessaryFullyQualifiedName in PredicateUtils
---
 src/changes/changes.xml                                           | 1 +
 src/main/java/org/apache/commons/collections4/PredicateUtils.java | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 97382084a..a554ef0b2 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -34,6 +34,7 @@
      <action issue="COLLECTIONS-853" type="fix" dev="aherbert" due-to="Claude 
Warren, Alex Herbert, Gary Gregory">Change LayerManager to use List and added 
generics to LayerdedBloomFilter #481.</action>
      <action type="update" dev="ggregory" due-to="PMD, Gary Gregory">Fix PMD 
UnnecessaryFullyQualifiedName in CollectionUtils.</action>
      <action type="update" dev="ggregory" due-to="PMD, Gary Gregory">Fix PMD 
UnnecessaryFullyQualifiedName in MapUtils.</action>
+     <action type="update" dev="ggregory" due-to="PMD, Gary Gregory">Fix PMD 
UnnecessaryFullyQualifiedName in PredicateUtils.</action>
      <!-- UPDATE -->
      <action type="update" dev="ggregory" due-to="Dependabot">Bump 
org.apache.commons:commons-parent from 67 to 69 #473.</action>
      <action type="update" dev="ggregory" due-to="Dependabot">Bump tests 
commons-io:commons-io from 2.16.0 to 2.16.1 #475.</action>
diff --git a/src/main/java/org/apache/commons/collections4/PredicateUtils.java 
b/src/main/java/org/apache/commons/collections4/PredicateUtils.java
index 4cb824932..8869fa1cb 100644
--- a/src/main/java/org/apache/commons/collections4/PredicateUtils.java
+++ b/src/main/java/org/apache/commons/collections4/PredicateUtils.java
@@ -179,7 +179,7 @@ public class PredicateUtils {
     public static <T> Predicate<T> eitherPredicate(final Predicate<? super T> 
predicate1,
                                                    final Predicate<? super T> 
predicate2) {
         @SuppressWarnings("unchecked")
-        final Predicate<T> onePredicate = 
PredicateUtils.onePredicate(predicate1, predicate2);
+        final Predicate<T> onePredicate = onePredicate(predicate1, predicate2);
         return onePredicate;
     }
 
@@ -252,7 +252,7 @@ public class PredicateUtils {
      * and have no parameters. If the input object is null, a
      * PredicateException is thrown.
      * <p>
-     * For example, {@code PredicateUtils.invokerPredicate("isEmpty");}
+     * For ePredicateUtils.invokerPredicate("isEmpty");}
      * will call the {@code isEmpty} method on the input object to
      * determine the predicate result.
      *
@@ -308,7 +308,7 @@ public class PredicateUtils {
     public static <T> Predicate<T> neitherPredicate(final Predicate<? super T> 
predicate1,
                                                     final Predicate<? super T> 
predicate2) {
         @SuppressWarnings("unchecked")
-        final Predicate<T> nonePredicate = 
PredicateUtils.nonePredicate(predicate1, predicate2);
+        final Predicate<T> nonePredicate = nonePredicate(predicate1, 
predicate2);
         return nonePredicate;
     }
 

Reply via email to