This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git
The following commit(s) were added to refs/heads/master by this push:
new fd778404 JaCoCo on Java 8 is different from other versions
fd778404 is described below
commit fd77840400c94eb7208c488ab664320a836e730a
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Apr 21 12:44:03 2024 -0400
JaCoCo on Java 8 is different from other versions
---
pom.xml | 28 ++++++++++------------------
1 file changed, 10 insertions(+), 18 deletions(-)
diff --git a/pom.xml b/pom.xml
index 5ab8fcb3..e9004324 100644
--- a/pom.xml
+++ b/pom.xml
@@ -68,7 +68,16 @@
<assertj.version>3.25.3</assertj.version>
<jna.version>5.14.0</jna.version>
<japicmp.skip>false</japicmp.skip>
- <commons.jacoco.haltOnFailure>false</commons.jacoco.haltOnFailure>
+ <commons.jacoco.haltOnFailure>true</commons.jacoco.haltOnFailure>
+
+ <!-- JaCoCo on Java 8 is different from other versions. On JDK9+ there is
a profile -->
+ <!-- JaCoCo: Don't make code coverage worse than: -->
+ <commons.jacoco.classRatio>0.89</commons.jacoco.classRatio>
+ <commons.jacoco.instructionRatio>0.65</commons.jacoco.instructionRatio>
+ <commons.jacoco.methodRatio>0.70</commons.jacoco.methodRatio>
+ <commons.jacoco.branchRatio>0.59</commons.jacoco.branchRatio>
+ <commons.jacoco.lineRatio>0.68</commons.jacoco.lineRatio>
+ <commons.jacoco.complexityRatio>0.58</commons.jacoco.complexityRatio>
</properties>
<distributionManagement>
@@ -519,23 +528,6 @@
</plugins>
</build>
</profile>
- <profile>
- <!-- Java 8 only -->
- <id>java-8</id>
- <activation>
- <jdk>8</jdk>
- </activation>
- <properties>
- <!-- JaCoCo on Java 8 is different from other versions. -->
- <!-- JaCoCo: Don't make code coverage worse than: -->
- <commons.jacoco.classRatio>0.89</commons.jacoco.classRatio>
- <commons.jacoco.instructionRatio>0.65</commons.jacoco.instructionRatio>
- <commons.jacoco.methodRatio>0.70</commons.jacoco.methodRatio>
- <commons.jacoco.branchRatio>0.59</commons.jacoco.branchRatio>
- <commons.jacoco.lineRatio>0.68</commons.jacoco.lineRatio>
- <commons.jacoco.complexityRatio>0.58</commons.jacoco.complexityRatio>
- </properties>
- </profile>
<profile>
<!-- Java 9 and up -->
<id>java-9-up</id>
