This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git


The following commit(s) were added to refs/heads/master by this push:
     new eba45c05 JaCoCo on Java 8 is different from other versions
eba45c05 is described below

commit eba45c05365fc89b0007296fc3ee188cca5d091d
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Apr 21 09:47:05 2024 -0400

    JaCoCo on Java 8 is different from other versions
---
 pom.xml | 29 ++++++++++++++++++++++-------
 1 file changed, 22 insertions(+), 7 deletions(-)

diff --git a/pom.xml b/pom.xml
index f0fe291f..aa349862 100644
--- a/pom.xml
+++ b/pom.xml
@@ -68,14 +68,7 @@
     <assertj.version>3.25.3</assertj.version>
     <jna.version>5.14.0</jna.version>
     <japicmp.skip>false</japicmp.skip>
-    <!-- JaCoCo: Don't make code coverage worse than: -->
     <commons.jacoco.haltOnFailure>true</commons.jacoco.haltOnFailure>
-    <commons.jacoco.classRatio>0.90</commons.jacoco.classRatio>
-    <commons.jacoco.instructionRatio>0.65</commons.jacoco.instructionRatio>
-    <commons.jacoco.methodRatio>0.70</commons.jacoco.methodRatio>
-    <commons.jacoco.branchRatio>0.58</commons.jacoco.branchRatio>
-    <commons.jacoco.lineRatio>0.68</commons.jacoco.lineRatio>
-    <commons.jacoco.complexityRatio>0.58</commons.jacoco.complexityRatio>
   </properties>
 
   <distributionManagement>
@@ -534,7 +527,29 @@
       </activation>
       <properties>
         <!-- JaCoCo on Java 8 is different from other versions. -->
+        <!-- JaCoCo: Don't make code coverage worse than: -->
         <commons.jacoco.classRatio>0.89</commons.jacoco.classRatio>
+        <commons.jacoco.instructionRatio>0.65</commons.jacoco.instructionRatio>
+        <commons.jacoco.methodRatio>0.70</commons.jacoco.methodRatio>
+        <commons.jacoco.branchRatio>0.58</commons.jacoco.branchRatio>
+        <commons.jacoco.lineRatio>0.68</commons.jacoco.lineRatio>
+        <commons.jacoco.complexityRatio>0.58</commons.jacoco.complexityRatio>
+      </properties>
+    </profile>
+    <profile>
+      <!-- Java 9 and up -->
+      <id>java-9-up</id>
+      <activation>
+        <jdk>[9,)</jdk>
+      </activation>
+      <properties>
+        <!-- JaCoCo: Don't make code coverage worse than: -->
+        <commons.jacoco.classRatio>0.90</commons.jacoco.classRatio>
+        <commons.jacoco.instructionRatio>0.65</commons.jacoco.instructionRatio>
+        <commons.jacoco.methodRatio>0.70</commons.jacoco.methodRatio>
+        <commons.jacoco.branchRatio>0.58</commons.jacoco.branchRatio>
+        <commons.jacoco.lineRatio>0.68</commons.jacoco.lineRatio>
+        <commons.jacoco.complexityRatio>0.58</commons.jacoco.complexityRatio>
       </properties>
     </profile>
   </profiles>

Reply via email to