(commons-validator) 04/23: Fix SpotBugs [ERROR] Medium: Inconsistent synchronization of org.apache.commons.validator.ValidatorAction.jsFunction; locked 62% of time [org.apache.commons.validator.ValidatorAction, org.apache.commons.validator.ValidatorAction, org.apache.commons.validator.ValidatorAction, org.apache.commons.validator.ValidatorAction, org.apache.commons.validator.ValidatorAction, org.apache.commons.validator.ValidatorAction, org.apache.commons.validator.ValidatorAction] Unsynchronized access at Validator [...]

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git

commit 5a91b2481f17fe23cd278d3d7fce630174e2d455
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Fri Dec 1 08:00:38 2023 -0500

    Fix SpotBugs [ERROR] Medium: Inconsistent synchronization of
    org.apache.commons.validator.ValidatorAction.jsFunction; locked 62% of
    time [org.apache.commons.validator.ValidatorAction,
    org.apache.commons.validator.ValidatorAction,
    org.apache.commons.validator.ValidatorAction,
    org.apache.commons.validator.ValidatorAction,
    org.apache.commons.validator.ValidatorAction,
    org.apache.commons.validator.ValidatorAction,
    org.apache.commons.validator.ValidatorAction] Unsynchronized access at
    ValidatorAction.java:[line 340]Unsynchronized access at
    ValidatorAction.java:[line 358]Synchronized access at
    ValidatorAction.java:[line 393]Synchronized access at
    ValidatorAction.java:[line 394]Synchronized access at
    ValidatorAction.java:[line 459]Synchronized access at
    ValidatorAction.java:[line 461]Synchronized access at
    ValidatorAction.java:[line 462] IS2_INCONSISTENT_SYNC
---
 src/changes/changes.xml                                         | 3 +++
 src/main/java/org/apache/commons/validator/ValidatorAction.java | 6 +++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 18b33169..f5ed9979 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -93,6 +93,9 @@ The <action> type attribute can be add,update,fix,remove.
     <action type="fix" dev="ggregory" due-to="Gary Gregory">
       Fix SpotBugs [ERROR] High: Found reliance on default encoding in 
org.apache.commons.validator.ValidatorAction.readJavascriptFile(String): new 
java.io.InputStreamReader(InputStream) 
[org.apache.commons.validator.ValidatorAction] At ValidatorAction.java:[line 
428] DM_DEFAULT_ENCODING.
     </action>
+    <action type="fix" dev="ggregory" due-to="Gary Gregory">
+      Fix SpotBugs [ERROR] Medium: Inconsistent synchronization of 
org.apache.commons.validator.ValidatorAction.jsFunction; locked 62% of time 
[org.apache.commons.validator.ValidatorAction, 
org.apache.commons.validator.ValidatorAction, 
org.apache.commons.validator.ValidatorAction, 
org.apache.commons.validator.ValidatorAction, 
org.apache.commons.validator.ValidatorAction, 
org.apache.commons.validator.ValidatorAction, 
org.apache.commons.validator.ValidatorAction] Unsynchronized access at V [...]
+    </action>
     <!-- ADD -->
     <action type="add" dev="ggregory" due-to="Dependabot, Gary Gregory">
       Add github/codeql-action.
diff --git a/src/main/java/org/apache/commons/validator/ValidatorAction.java 
b/src/main/java/org/apache/commons/validator/ValidatorAction.java
index 345b255d..6aed389d 100644
--- a/src/main/java/org/apache/commons/validator/ValidatorAction.java
+++ b/src/main/java/org/apache/commons/validator/ValidatorAction.java
@@ -332,7 +332,7 @@ public class ValidatorAction implements Serializable {
      * </pre>
      * @param jsFunction The Javascript function's fully qualified class path.
      */
-    public void setJsFunction(final String jsFunction) {
+    public synchronized void setJsFunction(final String jsFunction) {
         if (javascript != null) {
             throw new IllegalStateException("Cannot call setJsFunction() after 
calling setJavascript()");
         }
@@ -345,7 +345,7 @@ public class ValidatorAction implements Serializable {
      * associated with this action.
      * @return The Javascript validation.
      */
-    public String getJavascript() {
+    public synchronized String getJavascript() {
         return javascript;
     }
 
@@ -354,7 +354,7 @@ public class ValidatorAction implements Serializable {
      * associated with this action.
      * @param javascript The Javascript validation.
      */
-    public void setJavascript(final String javascript) {
+    public synchronized void setJavascript(final String javascript) {
         if (jsFunction != null) {
             throw new IllegalStateException("Cannot call setJavascript() after 
calling setJsFunction()");
         }