This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git
from 8b4b6cae Use try-with-resources
new 026d9040 Use try-with-resources
new f4aafcfa Fix SpotBugs [ERROR] High: Found reliance on default encoding
in org.apache.commons.validator.ValidatorAction.readJavascriptFile(String): new
java.io.InputStreamReader(InputStream)
[org.apache.commons.validator.ValidatorAction] At ValidatorAction.java:[line
428] DM_DEFAULT_ENCODING.
new 041edb4a use final
new 5a91b248 Fix SpotBugs [ERROR] Medium: Inconsistent synchronization of
org.apache.commons.validator.ValidatorAction.jsFunction; locked 62% of time
[org.apache.commons.validator.ValidatorAction,
org.apache.commons.validator.ValidatorAction,
org.apache.commons.validator.ValidatorAction,
org.apache.commons.validator.ValidatorAction,
org.apache.commons.validator.ValidatorAction,
org.apache.commons.validator.ValidatorAction,
org.apache.commons.validator.ValidatorAction] Unsynchronized [...]
new 76dcff61 Avoid possible NPE.
new cc98234c Javadoc
new 193bccbe Javadoc
new ea743f97 Refactor
new 4e70d3aa Organize test imports
new fcccf4f9 Sort members
new 0ae2dda1 Comment TODO
new 0ab71187 Comment TODO
new 05e86a6b Enable SpotBugs
new 4a83050e Format
new 5dd59ef9 Better error handling
new 6f45d5b8 Javadoc
new b563a079 Javadoc
new b3c11990 Javadoc
new 8d22a959 Spelling
new caf4a4bd Revert "Better error handling"
new 8d98a3df One new Spotbugs issue and one false positive
new 46859adb Start porting to JUnit 5 Add @Test annotations
new 8178e33f Fix spelling in Javadoc
The 23 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
pom.xml | 7 +-
src/changes/changes.xml | 6 +
src/conf/checkstyle.xml | 2 +-
src/conf/spotbugs-exclude-filter.xml | 41 +
.../commons/validator/CreditCardValidator.java | 142 +--
.../apache/commons/validator/DateValidator.java | 68 +-
.../apache/commons/validator/EmailValidator.java | 18 +-
.../java/org/apache/commons/validator/Field.java | 866 +++++++++---------
.../java/org/apache/commons/validator/Form.java | 156 ++--
.../java/org/apache/commons/validator/FormSet.java | 342 ++++----
.../apache/commons/validator/FormSetFactory.java | 42 +-
.../commons/validator/GenericTypeValidator.java | 360 ++++----
.../apache/commons/validator/GenericValidator.java | 278 +++---
.../java/org/apache/commons/validator/Msg.java | 64 +-
.../org/apache/commons/validator/UrlValidator.java | 116 +--
.../org/apache/commons/validator/Validator.java | 202 ++---
.../apache/commons/validator/ValidatorAction.java | 927 ++++++++++---------
.../commons/validator/ValidatorResources.java | 336 +++----
.../apache/commons/validator/ValidatorResult.java | 188 ++--
.../apache/commons/validator/ValidatorResults.java | 66 +-
.../java/org/apache/commons/validator/Var.java | 104 +--
.../routines/AbstractCalendarValidator.java | 472 +++++-----
.../routines/AbstractFormatValidator.java | 158 ++--
.../routines/AbstractNumberValidator.java | 250 +++---
.../validator/routines/BigDecimalValidator.java | 126 +--
.../validator/routines/BigIntegerValidator.java | 112 +--
.../commons/validator/routines/ByteValidator.java | 148 ++--
.../validator/routines/CalendarValidator.java | 262 +++---
.../commons/validator/routines/CodeValidator.java | 106 +--
.../validator/routines/CreditCardValidator.java | 335 +++----
.../commons/validator/routines/DateValidator.java | 266 +++---
.../validator/routines/DomainValidator.java | 940 ++++++++++----------
.../validator/routines/DoubleValidator.java | 148 ++--
.../commons/validator/routines/EmailValidator.java | 58 +-
.../commons/validator/routines/FloatValidator.java | 148 ++--
.../commons/validator/routines/IBANValidator.java | 128 +--
.../commons/validator/routines/ISBNValidator.java | 82 +-
.../commons/validator/routines/ISINValidator.java | 18 +-
.../commons/validator/routines/ISSNValidator.java | 74 +-
.../validator/routines/InetAddressValidator.java | 8 +-
.../validator/routines/IntegerValidator.java | 148 ++--
.../commons/validator/routines/LongValidator.java | 148 ++--
.../commons/validator/routines/RegexValidator.java | 58 +-
.../commons/validator/routines/ShortValidator.java | 148 ++--
.../commons/validator/routines/TimeValidator.java | 162 ++--
.../commons/validator/routines/UrlValidator.java | 246 +++---
.../routines/checkdigit/IBANCheckDigit.java | 46 +-
.../routines/checkdigit/ISBN10CheckDigit.java | 42 +-
.../routines/checkdigit/ISSNCheckDigit.java | 10 +-
.../routines/checkdigit/ModulusCheckDigit.java | 143 +--
.../routines/checkdigit/ModulusTenCheckDigit.java | 22 +-
.../routines/checkdigit/SedolCheckDigit.java | 28 +-
.../routines/checkdigit/VerhoeffCheckDigit.java | 38 +-
.../org/apache/commons/validator/util/Flags.java | 134 +--
.../commons/validator/util/ValidatorUtils.java | 160 ++--
.../commons/validator/AbstractCommonTest.java | 4 +-
.../commons/validator/AbstractNumberTest.java | 5 +-
.../org/apache/commons/validator/ByteTest.java | 40 +-
.../commons/validator/CreditCardValidatorTest.java | 54 +-
.../validator/CustomValidatorResourcesTest.java | 3 +
.../org/apache/commons/validator/DateTest.java | 15 +-
.../org/apache/commons/validator/DoubleTest.java | 20 +-
.../org/apache/commons/validator/EmailTest.java | 566 ++++++------
.../apache/commons/validator/EntityImportTest.java | 4 +
.../apache/commons/validator/ExceptionTest.java | 54 +-
.../apache/commons/validator/ExtensionTest.java | 138 +--
.../org/apache/commons/validator/FieldTest.java | 209 ++---
.../org/apache/commons/validator/FloatTest.java | 20 +-
.../validator/GenericTypeValidatorImpl.java | 114 +--
.../validator/GenericTypeValidatorTest.java | 126 +--
.../commons/validator/GenericValidatorImpl.java | 182 ++--
.../commons/validator/GenericValidatorTest.java | 46 +-
.../commons/validator/ISBNValidatorTest.java | 3 +
.../org/apache/commons/validator/IntegerTest.java | 42 +-
.../org/apache/commons/validator/LocaleTest.java | 6 +
.../org/apache/commons/validator/LongTest.java | 40 +-
.../commons/validator/MultipleConfigFilesTest.java | 198 +++--
.../org/apache/commons/validator/MultipleTest.java | 217 ++---
.../org/apache/commons/validator/NameBean.java | 16 +-
.../apache/commons/validator/ParameterTest.java | 40 +-
.../apache/commons/validator/RequiredIfTest.java | 42 +-
.../apache/commons/validator/RequiredNameTest.java | 45 +-
.../apache/commons/validator/RetrieveFormTest.java | 212 ++---
.../org/apache/commons/validator/ShortTest.java | 38 +-
.../org/apache/commons/validator/TypeBean.java | 52 +-
.../java/org/apache/commons/validator/UrlTest.java | 264 +++---
.../commons/validator/ValidatorResourcesTest.java | 3 +
.../commons/validator/ValidatorResultsTest.java | 71 +-
.../apache/commons/validator/ValidatorTest.java | 262 +++---
.../java/org/apache/commons/validator/VarTest.java | 4 +-
.../routines/AbstractCalendarValidatorTest.java | 156 ++--
.../routines/AbstractNumberValidatorTest.java | 160 ++--
.../routines/BigDecimalValidatorTest.java | 70 +-
.../routines/BigIntegerValidatorTest.java | 64 +-
.../validator/routines/ByteValidatorTest.java | 68 +-
.../validator/routines/CalendarValidatorTest.java | 101 ++-
.../validator/routines/CodeValidatorTest.java | 134 +--
.../routines/CreditCardValidatorTest.java | 493 ++++++-----
.../validator/routines/CurrencyValidatorTest.java | 124 +--
.../validator/routines/DateValidatorTest.java | 127 +--
.../routines/DomainValidatorStartupTest.java | 86 +-
.../validator/routines/DomainValidatorTest.java | 886 ++++++++++---------
.../validator/routines/DoubleValidatorTest.java | 64 +-
.../validator/routines/EmailValidatorTest.java | 639 +++++++-------
.../validator/routines/FloatValidatorTest.java | 103 +--
.../validator/routines/IBANValidatorTest.java | 258 +++---
.../validator/routines/ISBNValidatorTest.java | 188 ++--
.../validator/routines/ISINValidatorTest.java | 18 +-
.../validator/routines/ISSNValidatorTest.java | 140 +--
.../routines/InetAddressValidatorTest.java | 154 ++--
.../validator/routines/IntegerValidatorTest.java | 65 +-
.../validator/routines/LongValidatorTest.java | 64 +-
.../validator/routines/PercentValidatorTest.java | 47 +-
.../validator/routines/RegexValidatorTest.java | 10 +
.../validator/routines/ShortValidatorTest.java | 68 +-
.../validator/routines/TimeValidatorTest.java | 249 +++---
.../validator/routines/UrlValidatorTest.java | 976 ++++++++++-----------
.../checkdigit/AbstractCheckDigitTest.java | 238 ++---
.../routines/checkdigit/CUSIPCheckDigitTest.java | 18 +-
.../routines/checkdigit/IBANCheckDigitTest.java | 139 +--
.../routines/checkdigit/ISBNCheckDigitTest.java | 3 +
.../routines/checkdigit/ISINCheckDigitTest.java | 21 +-
.../checkdigit/ModulusTenCUSIPCheckDigitTest.java | 18 +-
.../checkdigit/ModulusTenSedolCheckDigitTest.java | 19 +-
.../routines/checkdigit/SedolCheckDigitTest.java | 19 +-
.../checkdigit/VerhoeffCheckDigitTest.java | 3 +
.../apache/commons/validator/util/FlagsTest.java | 107 ++-
127 files changed, 9680 insertions(+), 9275 deletions(-)
create mode 100644 src/conf/spotbugs-exclude-filter.xml
