This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
The following commit(s) were added to refs/heads/master by this push:
new bc51547e Fix SpotBugs errors
bc51547e is described below
commit bc51547e7c8619163078ec81938babf6733777f5
Author: Gary Gregory <[email protected]>
AuthorDate: Thu Nov 23 13:26:55 2023 -0500
Fix SpotBugs errors
[ERROR] Medium:
org.apache.commons.io.input.ObservableInputStream.getObservers() may
expose internal representation by returning
ObservableInputStream.observers
[org.apache.commons.io.input.ObservableInputStream]
At ObservableInputStream.java:[line 187] EI_EXPOSE_REP
---
src/changes/changes.xml | 1 +
.../java/org/apache/commons/io/input/ObservableInputStream.java | 6 +++---
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 2a27ab63..8f09cdf9 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -67,6 +67,7 @@ The <action> type attribute can be add,update,fix,remove.
<action dev="ggregory" type="fix" due-to="Gary Gregory">Fix SpotBugs
error: org.apache.commons.io.IOExceptionList.getCauseList(Class) may expose
internal representation by returning IOExceptionList.causeList
[org.apache.commons.io.IOExceptionList] At IOExceptionList.java:[line 129]
EI_EXPOSE_REP.</action>
<action dev="ggregory" type="fix" due-to="Gary Gregory">Fix SpotBugs
error: org.apache.commons.io.file.AccumulatorPathVisitor.getDirList() may
expose internal representation by returning AccumulatorPathVisitor.dirList
[org.apache.commons.io.file.AccumulatorPathVisitor] At
AccumulatorPathVisitor.java:[line 179] EI_EXPOSE_REP.</action>
<action dev="ggregory" type="fix" due-to="Gary Gregory">Fix SpotBugs
error: org.apache.commons.io.file.AccumulatorPathVisitor.getFileList() may
expose internal representation by returning AccumulatorPathVisitor.fileList
[org.apache.commons.io.file.AccumulatorPathVisitor] At
AccumulatorPathVisitor.java:[line 188] EI_EXPOSE_REP.</action>
+ <action dev="ggregory" type="fix" due-to="Gary Gregory">Fix SpotBugs
error: org.apache.commons.io.input.ObservableInputStream.getObservers() may
expose internal representation by returning ObservableInputStream.observers
[org.apache.commons.io.input.ObservableInputStream] At
ObservableInputStream.java:[line 187] EI_EXPOSE_REP.</action>
<!-- UPDATE -->
<action dev="ggregory" type="update" due-to="Gary Gregory">Bump
org.codehaus.mojo:exec-maven-plugin from 3.1.0 to 3.1.1 #512.</action>
<action dev="ggregory" type="update" due-to="Gary Gregory">Bump
commons-lang3 from 3.13.0 to 3.14.0.</action>
diff --git
a/src/main/java/org/apache/commons/io/input/ObservableInputStream.java
b/src/main/java/org/apache/commons/io/input/ObservableInputStream.java
index a97702fb..5fd27b2c 100644
--- a/src/main/java/org/apache/commons/io/input/ObservableInputStream.java
+++ b/src/main/java/org/apache/commons/io/input/ObservableInputStream.java
@@ -178,13 +178,13 @@ public class ObservableInputStream extends
ProxyInputStream {
}
/**
- * Gets all currently registered observers.
+ * Gets a copy of currently registered observers.
*
- * @return a list of the currently registered observers.
+ * @return a copy of the list of currently registered observers.
* @since 2.9.0
*/
public List<Observer> getObservers() {
- return observers;
+ return new ArrayList<>(observers);
}
/**
