This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git


The following commit(s) were added to refs/heads/master by this push:
     new c39be8e3 Fix SpotBugs errors
c39be8e3 is described below

commit c39be8e39a24198725a105170464b74c40ba1083
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Thu Nov 23 11:57:05 2023 -0500

    Fix SpotBugs errors
    
    - [ERROR] Medium: Class
    org.apache.commons.io.monitor.FileAlterationObserver defines
    non-transient non-serializable instance field fileFilter
    [org.apache.commons.io.monitor.FileAlterationObserver] In
    FileAlterationObserver.java SE_BAD_FIELD
    - [ERROR] Medium: Class
    org.apache.commons.io.monitor.FileAlterationObserver defines
    non-transient non-serializable instance field listeners
    [org.apache.commons.io.monitor.FileAlterationObserver] In
    FileAlterationObserver.java SE_BAD_FIELD
---
 src/changes/changes.xml                                               | 2 ++
 .../java/org/apache/commons/io/monitor/FileAlterationObserver.java    | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 6518d1dc..741fd2d9 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -59,6 +59,8 @@ The <action> type attribute can be add,update,fix,remove.
       <action dev="ggregory" type="fix" due-to="Gary Gregory">Fix SpotBugs 
error: Class org.apache.commons.io.filefilter.DelegateFileFilter defines 
non-transient non-serializable instance field fileFilter 
[org.apache.commons.io.filefilter.DelegateFileFilter] In 
DelegateFileFilter.java SE_BAD_FIELD.</action>
       <action dev="ggregory" type="fix" due-to="Gary Gregory">Fix SpotBugs 
error: Class org.apache.commons.io.filefilter.DelegateFileFilter defines 
non-transient non-serializable instance field fileNameFilter 
[org.apache.commons.io.filefilter.DelegateFileFilter] In 
DelegateFileFilter.java SE_BAD_FIELD.</action>
       <action dev="ggregory" type="fix" due-to="Gary Gregory">Fix SpotBugs 
error: org.apache.commons.io.function.IOStream$1.next() cannot throw 
NoSuchElementException [org.apache.commons.io.function.IOStream$1] At 
IOStream.java:[line 98] IT_NO_SUCH_ELEMENT.</action>
+      <action dev="ggregory" type="fix" due-to="Gary Gregory">Fix SpotBugs 
error: Class org.apache.commons.io.monitor.FileAlterationObserver defines 
non-transient non-serializable instance field fileFilter 
[org.apache.commons.io.monitor.FileAlterationObserver] In 
FileAlterationObserver.java SE_BAD_FIELD.</action>
+      <action dev="ggregory" type="fix" due-to="Gary Gregory">Fix SpotBugs 
error: Class org.apache.commons.io.monitor.FileAlterationObserver defines 
non-transient non-serializable instance field listeners 
[org.apache.commons.io.monitor.FileAlterationObserver] In 
FileAlterationObserver.java SE_BAD_FIELD.</action>
       <!-- UPDATE -->
       <action dev="ggregory" type="update" due-to="Gary Gregory">Bump 
org.codehaus.mojo:exec-maven-plugin from 3.1.0 to 3.1.1 #512.</action>
       <action dev="ggregory" type="update" due-to="Gary Gregory">Bump 
commons-lang3 from 3.13.0 to 3.14.0.</action>      
diff --git 
a/src/main/java/org/apache/commons/io/monitor/FileAlterationObserver.java 
b/src/main/java/org/apache/commons/io/monitor/FileAlterationObserver.java
index d34e825b..33311b53 100644
--- a/src/main/java/org/apache/commons/io/monitor/FileAlterationObserver.java
+++ b/src/main/java/org/apache/commons/io/monitor/FileAlterationObserver.java
@@ -128,9 +128,9 @@ import org.apache.commons.io.comparator.NameFileComparator;
 public class FileAlterationObserver implements Serializable {
 
     private static final long serialVersionUID = 1185122225658782848L;
-    private final List<FileAlterationListener> listeners = new 
CopyOnWriteArrayList<>();
+    private transient final List<FileAlterationListener> listeners = new 
CopyOnWriteArrayList<>();
     private final FileEntry rootEntry;
-    private final FileFilter fileFilter;
+    private transient final FileFilter fileFilter;
     private final Comparator<File> comparator;
 
     /**

Reply via email to