[commons-fileupload] 09/21: Remove unnecessary code

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 1.x
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git

commit 86d1a300a0a532cc0097be891e97dc01f972dc68
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri Sep 15 19:09:05 2023 +0100

    Remove unnecessary code
---
 src/main/java/org/apache/commons/fileupload/FileUpload.java       | 2 --
 src/main/java/org/apache/commons/fileupload/FileUploadBase.java   | 8 ++------
 .../java/org/apache/commons/fileupload/disk/DiskFileItem.java     | 1 -
 3 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/src/main/java/org/apache/commons/fileupload/FileUpload.java 
b/src/main/java/org/apache/commons/fileupload/FileUpload.java
index 011a56cc..7b843b5c 100644
--- a/src/main/java/org/apache/commons/fileupload/FileUpload.java
+++ b/src/main/java/org/apache/commons/fileupload/FileUpload.java
@@ -52,7 +52,6 @@ public class FileUpload
      * @see #FileUpload(FileItemFactory)
      */
     public FileUpload() {
-        super();
     }
 
     /**
@@ -63,7 +62,6 @@ public class FileUpload
      * @param fileItemFactory The factory to use for creating file items.
      */
     public FileUpload(final FileItemFactory fileItemFactory) {
-        super();
         this.fileItemFactory = fileItemFactory;
     }
 
diff --git a/src/main/java/org/apache/commons/fileupload/FileUploadBase.java 
b/src/main/java/org/apache/commons/fileupload/FileUploadBase.java
index ecf90b1b..9fd5aea4 100644
--- a/src/main/java/org/apache/commons/fileupload/FileUploadBase.java
+++ b/src/main/java/org/apache/commons/fileupload/FileUploadBase.java
@@ -77,10 +77,7 @@ public abstract class FileUploadBase {
         if (contentType == null) {
             return false;
         }
-        if (contentType.toLowerCase(Locale.ENGLISH).startsWith(MULTIPART)) {
-            return true;
-        }
-        return false;
+        return contentType.toLowerCase(Locale.ENGLISH).startsWith(MULTIPART);
     }
 
     /**
@@ -709,8 +706,7 @@ public abstract class FileUploadBase {
             return;
         }
         final String headerName = header.substring(0, colonOffset).trim();
-        final String headerValue =
-            header.substring(header.indexOf(':') + 1).trim();
+        final String headerValue = header.substring(colonOffset + 1).trim();
         headers.addHeader(headerName, headerValue);
     }
 
diff --git a/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java 
b/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java
index 98d78773..c7708bbd 100644
--- a/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java
+++ b/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java
@@ -389,7 +389,6 @@ public class DiskFileItem
             try {
                 fout = new FileOutputStream(file);
                 fout.write(get());
-                fout.close();
             } finally {
                 IOUtils.closeQuietly(fout);
             }