[commons-fileupload] 10/21: Failure to delete an existing file should trigger an exception

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 1.x
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git

commit 7461ba33d9c84b605a69c387a29633c9f9b9023f
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri Sep 15 19:26:53 2023 +0100

    Failure to delete an existing file should trigger an exception
---
 src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java 
b/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java
index c7708bbd..4534ada9 100644
--- a/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java
+++ b/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java
@@ -409,8 +409,8 @@ public class DiskFileItem
              * in a temporary location so move it to the
              * desired file.
              */
-            if (file.exists()) {
-                file.delete();
+            if (file.exists() && !file.delete()) {
+                throw new FileUploadException("Cannot write uploaded file to 
disk!");
             }
             FileUtils.moveFile(outputFile, file);
         }