lukasz-antoniak commented on code in PR #193:
URL:
https://github.com/apache/cassandra-analytics/pull/193#discussion_r3027626530
##########
cassandra-four-zero-bridge/src/test/java/org/apache/cassandra/io/util/CdcRandomAccessReaderTest.java:
##########
@@ -92,9 +92,9 @@ public void testCDCRebufferSequentialReading() throws
IOException
long position = call.start;
// Deliver data in chunks until request is fulfilled
- while (position < actualEnd)
+ while (position <= actualEnd) // range boundaries are inclusive
Review Comment:
According to below JavaDoc, ranges should be consider inclusive.
```
/**
* Asynchronously request bytes for the SSTable file component in the range
start-end, and pass on to the StreamConsumer when available.
* The start-end range is inclusive.
*
* @param start the start of the bytes range
* @param end the end of the bytes range
* @param consumer the StreamConsumer to return the bytes to when the
request is complete
*/
void request(long start, long end, StreamConsumer consumer);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
