lukasz-antoniak commented on code in PR #193:
URL:
https://github.com/apache/cassandra-analytics/pull/193#discussion_r3027611441
##########
cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/utils/BufferingInputStreamTests.java:
##########
@@ -289,7 +293,7 @@ public Duration timeout()
};
int bytesToRead = chunkSize * numChunks;
- long skipAhead = size - bytesToRead + 1;
+ long skipAhead = size - bytesToRead;
Review Comment:
I am not sure how effective the change in `BufferingInputStream` would
affect `skip()` used during BIG index reading. All integration tests pass
though, and I think hereby unit test is just a simulation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
