jyothsnakonisa commented on code in PR #188:
URL:
https://github.com/apache/cassandra-analytics/pull/188#discussion_r3017366745
##########
cassandra-analytics-cdc-sidecar/src/main/java/org/apache/cassandra/cdc/sidecar/SidecarCdc.java:
##########
@@ -75,6 +75,27 @@ public static SidecarCdcBuilder builder(@NotNull String
jobId,
cdcStats);
}
Review Comment:
good catch, this is no longer needed and we should remove it as the builder
path creates new SidecarCdcClient.
I also think, we should remove the constructor which creates new
SidecarCdcClient in the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
