yifan-c commented on code in PR #188:
URL:
https://github.com/apache/cassandra-analytics/pull/188#discussion_r3013609682
##########
cassandra-analytics-cdc-sidecar/src/main/java/org/apache/cassandra/cdc/sidecar/SidecarCdcClient.java:
##########
@@ -52,21 +56,42 @@
import static org.apache.cassandra.spark.utils.Properties.DEFAULT_SIDECAR_PORT;
import static
org.apache.cassandra.spark.utils.Properties.DEFAULT_TIMEOUT_SECONDS;
-public class SidecarCdcClient
+public class SidecarCdcClient implements AutoCloseable
{
final ClientConfig config;
final SidecarClient sidecarClient;
final ICdcStats stats;
- public SidecarCdcClient(ClientConfig config,
- SidecarClient sidecarClient,
- ICdcStats stats)
+ public SidecarCdcClient(ClientConfig clientConfig,
+ CdcSidecarInstancesProvider instancesProvider,
+ SecretsProvider secretsProvider,
+ ICdcStats cdcStats) throws IOException
+ {
+ this(clientConfig,
+ Sidecar.from(new
SimpleSidecarInstancesProvider(instancesProvider.instances()
+
.stream()
+
.map(i -> new SidecarInstanceImpl(i.hostname(), i.port()))
+
.collect(Collectors.toList())),
+ clientConfig.toGenericSidecarConfig(),
+ secretsProvider),
+ cdcStats);
+ }
+
+ private SidecarCdcClient(ClientConfig config,
+ SidecarClient sidecarClient,
+ ICdcStats stats)
{
this.config = config;
this.sidecarClient = sidecarClient;
this.stats = stats;
}
+ @Override
+ public void close() throws Exception
+ {
+ sidecarClient.close();
+ }
Review Comment:
Please add a detailed comment to explain who closes the shared client and
when it is closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
