skoppu22 commented on code in PR #181:
URL:
https://github.com/apache/cassandra-analytics/pull/181#discussion_r2924675395
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkSparkConf.java:
##########
@@ -207,6 +208,7 @@ public BulkSparkConf(SparkConf conf, Map<String, String>
options, @Nullable Logg
this.ttl = MapUtils.getOrDefault(options, WriterOptions.TTL.name(),
null);
this.timestamp = MapUtils.getOrDefault(options,
WriterOptions.TIMESTAMP.name(), null);
this.quoteIdentifiers = MapUtils.getBoolean(options,
WriterOptions.QUOTE_IDENTIFIERS.name(), false, "quote identifiers");
+ this.skipSecondaryIndexCheck = MapUtils.getBoolean(options,
WriterOptions.SKIP_SECONDARY_INDEX_CHECK.name(), false, "skip secondary index
check");
Review Comment:
I believe default value shouldn't be true, because user need to understand
that rebuild need to happen after the job.
@jmckenzie-dev can we print a note/warning to the user mentioning rebuild
needs to happen after the job, so they are aware of penalty of using this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
