jmckenzie-dev commented on PR #181: URL: https://github.com/apache/cassandra-analytics/pull/181#issuecomment-4042186165
> Would it be useful to test writer with this flag in integration test too? Eh, I didn't because ultimately it's a validation error inside the `TableSchema` construction so basically, if we can get past that point then we should be good to go. The rest of the integration path would effectively be testing whether bulk import on cassandra with a table that has legacy SecondaryIndexes on it works correctly. Which, to be completely honest, I'm not super confident of (dug around a bit and `ImportTest.java` doesn't seem to have coverage). BUT - that's a core C* test coverage problem and not an analytics / sidecar problem. So maybe a follow up JIRA to add test coverage in C* proper for legacy 2i on imports would be reasonable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
