lukasz-antoniak commented on code in PR #175:
URL:
https://github.com/apache/cassandra-analytics/pull/175#discussion_r2924017812
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/cdc/msg/RangeTombstoneBuilder.java:
##########
@@ -25,40 +25,22 @@
/**
* Keep track of the last range tombstone marker to build {@link
RangeTombstone}
* The caller should check whether {@link #canBuild()} after adding marker,
and it should build whenever possible.
+ * IMPLEMENTATION NOTE: Refactored from abstract class to interface, due to
classloader clash. Superclass is loaded
+ * by application classloader, but concrete implementation (from bridge
module) with dedicated classloader.
*
* @param <T>
*/
-public abstract class RangeTombstoneBuilder<T>
+public interface RangeTombstoneBuilder<T>
{
- RangeTombstone rangeTombstone;
- boolean expectOpen = true;
-
- public RangeTombstone buildTombstone(List<Value> start, boolean
isStartInclusive, List<Value> end, boolean isEndInclusive)
- {
- return new RangeTombstone(start, isStartInclusive, end,
isEndInclusive);
- }
-
- public boolean canBuild()
- {
- return rangeTombstone != null;
- }
-
- public RangeTombstone build()
- {
- RangeTombstone res = rangeTombstone;
- rangeTombstone = null;
- return res;
- }
-
- public abstract void add(T marker);
+ RangeTombstone buildTombstone(List<Value> start, boolean isStartInclusive,
List<Value> end, boolean isEndInclusive);
+ boolean canBuild();
+ RangeTombstone build();
+ void add(T marker);
Review Comment:
They are little self-explanatory and not sure if JavaDoc will add much more
value. Do you have something on your mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
