lukasz-antoniak commented on code in PR #175:
URL:
https://github.com/apache/cassandra-analytics/pull/175#discussion_r2924001784
##########
cassandra-five-zero-bridge/src/main/java/org/apache/cassandra/bridge/CdcBridgeImplementation.java:
##########
@@ -67,6 +67,8 @@ protected static synchronized void setCDC(Path path, int
commitLogSegmentSize, b
DatabaseDescriptor.setCommitLogSyncGroupWindow(30);
DatabaseDescriptor.setCommitLogSegmentSize(commitLogSegmentSize);
DatabaseDescriptor.getRawConfig().commitlog_total_space = new
DataStorageSpec.IntMebibytesBound(1024);
+
DatabaseDescriptor.setCommitLogWriteDiskAccessMode(Config.DiskAccessMode.direct);
Review Comment:
We do not seem to have an option to skip this setting. Only `mmap` and
`direct` are supported based on 5.0.5 code. `direct` seemed like a safer
option. `AbstractCommitLogSegmentManager#createSegmentBuilder` uses other modes
for encrypted or compressed commit logs automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
