lukasz-antoniak commented on code in PR #131:
URL:
https://github.com/apache/cassandra-analytics/pull/131#discussion_r2273172498
##########
cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/bulkwriter/RecordWriterTest.java:
##########
@@ -74,8 +78,12 @@ class RecordWriterTest
{
private static final int REPLICA_COUNT = 3;
private static final int FILES_PER_SSTABLE = 8;
- // writing 270 rows with sstable size cap of 1 MB should produce 2 sstable
- private static final int UPLOADED_SSTABLES = 2;
+ // writing 270 rows with sstable size cap of 1 MB should produce 2
sstables (Cassandra 4) or 3 sstables (Cassandra 5)
+ private static final Map<Integer, Integer>
UPLOADED_SSTABLES_PER_CASSANDRA_VERSION = ImmutableMap.<Integer,
Integer>builder()
+
.put(40, 2)
+
.put(41, 2)
+
.put(50, 3)
Review Comment:
Thank you very much for this finding!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
