lukasz-antoniak commented on code in PR #131:
URL:
https://github.com/apache/cassandra-analytics/pull/131#discussion_r2273134738
##########
cassandra-analytics-cdc/build.gradle:
##########
@@ -67,15 +86,22 @@ dependencies {
implementation
"com.fasterxml.jackson.core:jackson-annotations:${jacksonVersion}"
implementation "com.fasterxml.jackson.core:jackson-core:${jacksonVersion}"
implementation
"com.fasterxml.jackson.core:jackson-databind:${jacksonVersion}"
+ implementation
"com.fasterxml.jackson.datatype:jackson-datatype-jsr310:${jacksonVersion}"
testImplementation project(":cassandra-analytics-common")
// pull in cassandra-bridge so we can re-use TestSchema to generate
arbitrary schemas for the cdc tests
testImplementation project(":cassandra-bridge")
testImplementation(testFixtures(project(':cassandra-bridge')))
- testImplementation project(":cassandra-four-zero-bridge")
+
testImplementation project(":cassandra-four-zero-types")
+ testImplementation project(":cassandra-four-zero-bridge")
testImplementation project(path: ':cassandra-four-zero', configuration:
'shadow')
+ // unit tests are performed only with Cassandra 4
+ // testImplementation project(":cassandra-five-zero-bridge")
+ // testImplementation project(":cassandra-five-zero-types")
+ // testImplementation project(path: ':cassandra-five-zero', configuration:
'shadow')
Review Comment:
I noticed that CDC tests did not support multi-bridge execution. Should we
implement it as part of this ticket, leave it to run with 4.x, or move to 5.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
