zregvart commented on a change in pull request #428:
URL: https://github.com/apache/camel-website/pull/428#discussion_r455963444
##########
File path: antora-ui-camel/src/js/06-mobile-footer.js
##########
@@ -0,0 +1,15 @@
+document.addEventListener('DOMContentLoaded', function () {
Review comment:
I think it's debatable if the using `:checked` selector and checkboxes
should or should not be used. I think it's fairly common practice that got
labeled a hack in the beginning and can't shake this image. For me it's about
the simplicity of the solution rather than the technique, and I think in this
case we do not need to use JavaScript.
Perhaps more appropriate no-JavaScript solution could be using the
[`:target` CSS](https://developer.mozilla.org/en-US/docs/Web/CSS/:target)
selector.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
