AemieJ commented on a change in pull request #428:
URL: https://github.com/apache/camel-website/pull/428#discussion_r455232658
##########
File path: antora-ui-camel/src/js/06-mobile-footer.js
##########
@@ -0,0 +1,15 @@
+document.addEventListener('DOMContentLoaded', function () {
Review comment:
* Well that's a creative checkbox hack and I am aware of it but I
prevented using it 'cause it is a CSS hack.
* Another point I would like to raise is even if I were to use a CSS hack
with a checkbox for toggling for the footer scenario then we shouldn't use
javascript for the navbar burger and dropdown arrow toggling as well, I believe.
* I prefer javascript for toggling personally, it's not a hack and is
certain to work in any case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
