ppalaga commented on a change in pull request #1088: Lightweight context
without init / start phases
URL: https://github.com/apache/camel-quarkus/pull/1088#discussion_r409371224
##########
File path:
extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/CamelConfig.java
##########
@@ -62,6 +62,13 @@
@ConfigItem(defaultValue = "true")
public boolean enabled;
+ /**
+ * If {@code true}, the camel context will be started at
initialization time
+ * to boot up faster.
Review comment:
> As far as I can understand the option moves camel context start from
RUNTIME_INIT to STATIC_INIT. If so, the JavaDoc should not hesitate to use
those concepts and should refer to
https://quarkus.io/guides/writing-extensions#bootstrap-three-phases for the
definitions of the terms.
After studying the changes more, I see that this flag does not move camel
context start from RUNTIME_INIT to STATIC_INIT as I thought before. It is
rather selecting a different "lightweight but limited" CamelContext
implementation. The doc text should say so. It should not say anything about
shifting start time, because it is not true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
