ppalaga commented on a change in pull request #1088: Lightweight context without init / start phases URL: https://github.com/apache/camel-quarkus/pull/1088#discussion_r409363846
########## File path: extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelInitializedReactiveExecutorBuildItem.java ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.quarkus.core.deployment; + +import io.quarkus.builder.item.SimpleBuildItem; +import io.quarkus.runtime.RuntimeValue; +import org.apache.camel.spi.ReactiveExecutor; + +/** + * Holds the initialized {@link ReactiveExecutor} {@link RuntimeValue}. Review comment: I'd appreciate a bit more explanations here: What does "initialized" mean here? Esp. what does that mean for the potential consumers of this BuildItem? When should they consume this one rather then the plain CamelReactiveExecutorBuildItem? Similarly the CamelReactiveExecutorBuildItem should give hints when to use that one vs. this one. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
