lburgazzoli commented on a change in pull request #153: Support Knative
broker/trigger model
URL: https://github.com/apache/camel-k-runtime/pull/153#discussion_r334425951
##########
File path:
camel-knative/camel-knative-api/src/main/java/org/apache/camel/component/knative/spi/Knative.java
##########
@@ -40,13 +37,18 @@
private Knative() {
}
+ public enum Kind {
Review comment:
I think we can use some "namespace" to distinguish things like:
- `camel.endpoint.kind` for source vs sink
- `knative.kind` and `knative.apiVersion` for additional kantive metadata
So a service is always identified by is name then some additional filtering
logic can be applied on the endpoint side depending on the options provided
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
