lburgazzoli commented on a change in pull request #153: Support Knative
broker/trigger model
URL: https://github.com/apache/camel-k-runtime/pull/153#discussion_r334386114
##########
File path:
camel-knative/camel-knative-api/src/main/java/org/apache/camel/component/knative/spi/Knative.java
##########
@@ -40,13 +37,18 @@
private Knative() {
}
+ public enum Kind {
+ source,
+ sink,
+ }
+
public enum Type {
endpoint,
- channel
+ channel,
+ event
}
public enum Protocol {
http,
- https
Review comment:
because we do not have a real support for https now, i.t. it lacks all the
options to set up the ssl context so removed to avoid confusion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
