davsclaus commented on code in PR #30371:
URL: https://github.com/apache/camel/pull/30371#discussion_r4626285726


##########
components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java:
##########
@@ -96,6 +96,8 @@ public class SmppConfiguration implements Cloneable {
     private int maxReconnect = Integer.MAX_VALUE;
     @UriParam(label = "producer")
     private boolean lazySessionCreation;
+    @UriParam(label = "producer,security")
+    private boolean allowSystemIdAndPasswordFromHeaders;

Review Comment:
   `insecure:dev` is for development and debug features (dev console, debugger 
breakpoints), and the other categories are `ssl` and `serialization`; none fits 
a header opt-in. Similar header opt-ins (`allowPartClassFromHeader` in 
camel-jaxb, `allowSecretStoreAndKeyFromHeaders` in camel-dapr) have no 
`security` category either. The option is off by default and labelled 
`security`. A new category would be a framework-wide change, separate from this 
PR.
   
   _Claude Code on behalf of Claus Ibsen_



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to