gnodet-bot commented on code in PR #30371:
URL: https://github.com/apache/camel/pull/30371#discussion_r4625489450


##########
components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppConfiguration.java:
##########
@@ -96,6 +96,8 @@ public class SmppConfiguration implements Cloneable {
     private int maxReconnect = Integer.MAX_VALUE;
     @UriParam(label = "producer")
     private boolean lazySessionCreation;
+    @UriParam(label = "producer,security")
+    private boolean allowSystemIdAndPasswordFromHeaders;

Review Comment:
   ⚠️ **Missing `security` policy attributes.** This option allows message 
headers to override the SMPP credentials used for connecting to the SMSC — a 
security-sensitive capability. Without `security` and `insecureValue` 
attributes, Camel's startup security policy enforcement 
(`camel.main.security-...`) cannot gate it.
   
   Per `design/security.adoc`, security-sensitive boolean flags enabling 
insecure behavior should declare their category and the value that triggers it:
   
   ```suggestion
       @UriParam(label = "producer,security", security = "insecure:dev", 
insecureValue = "true")
       private boolean allowSystemIdAndPasswordFromHeaders;
   ```
   
   `insecure:dev` is the appropriate category — this is a credential override 
capability that is intentionally unsafe in production without explicit opt-in.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to