davsclaus commented on code in PR #30132:
URL: https://github.com/apache/camel/pull/30132#discussion_r4600346463


##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc:
##########
@@ -7841,6 +7841,17 @@ resumed after the failed record. The new consumer leaves 
and rejoins the consume
 rebalance of the group, also when the partition has a committed offset. There 
is no option to keep the previous
 behaviour.
 
+=== camel-kafka - breakOnFirstError: a failed commit before the break goes to 
the exception handler
+
+With `breakOnFirstError=true`, the commit that the consumer makes before it 
breaks out on a failed record can fail or
+time out (for example a `TimeoutException` of `commitSync` with the 
`SyncCommitManager`). That failure is now reported
+to the `ExceptionHandler` of the consumer, and the consumer still breaks out 
and polls again from the last committed
+offset. Before, it went to the `pollOnError` strategy, and with 
`ERROR_HANDLER` (the default), `DISCARD` or `RETRY`
+the failed record and the rest of the poll were skipped.
+The failure no longer reaches the error handler of the route (such as an 
`onException` that caught commit timeouts)
+unless `bridgeErrorHandler=true`, and with `pollOnError=STOP` the consumer now 
reconnects in this case instead of
+stopping.

Review Comment:
   Done in 8d608d8517fe: the sentence is split in two, "... unless 
`bridgeErrorHandler=true`. With `pollOnError=STOP`, the consumer now reconnects 
in this case instead of stopping."
   
   _Claude Code on behalf of davsclaus_



##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc:
##########
@@ -7841,6 +7841,17 @@ resumed after the failed record. The new consumer leaves 
and rejoins the consume
 rebalance of the group, also when the partition has a committed offset. There 
is no option to keep the previous
 behaviour.
 
+=== camel-kafka - breakOnFirstError: a failed commit before the break goes to 
the exception handler
+
+With `breakOnFirstError=true`, the commit that the consumer makes before it 
breaks out on a failed record can fail or
+time out (for example a `TimeoutException` of `commitSync` with the 
`SyncCommitManager`). That failure is now reported
+to the `ExceptionHandler` of the consumer, and the consumer still breaks out 
and polls again from the last committed
+offset. Before, it went to the `pollOnError` strategy, and with 
`ERROR_HANDLER` (the default), `DISCARD` or `RETRY`
+the failed record and the rest of the poll were skipped.

Review Comment:
   Done in 8d608d8517fe: the first sentence is shorter, the passive voice is 
gone ("The consumer now reports that failure to its `ExceptionHandler`"), and 
the ambiguous "it" is now "the commit failure".
   
   _Claude Code on behalf of davsclaus_



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to