gnodet-bot commented on code in PR #30132:
URL: https://github.com/apache/camel/pull/30132#discussion_r4581081937
##########
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/consumer/support/streaming/KafkaRecordStreamingProcessor.java:
##########
@@ -730,9 +733,22 @@ private boolean processException(
// when route uses Synch/Asynch Commit Manager it will
// ALWAYS commit the offset for the failing record
// and will ALWAYS retry it
Review Comment:
⚠️ **Stale comment** — after the fix, the commit may fail (e.g.
`TimeoutException`) and not be applied; the break happens regardless. "ALWAYS
commit" and "ALWAYS retry" are no longer accurate.
```suggestion
// when route uses NOOP Commit Manager it will rely
// on the route implementation to explicitly commit offset
// when route uses Synch/Asynch Commit Manager, the commit of
the break can fail
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]