gnodet-bot commented on code in PR #29579:
URL: https://github.com/apache/camel/pull/29579#discussion_r4531547401
##########
core/camel-util/src/main/java/org/apache/camel/util/ObjectHelper.java:
##########
@@ -253,7 +253,7 @@ public static <T> boolean isNotEmpty(T value) {
}
/**
- * Tests whether the value is <b>not</b> <tt>null</tt> or an empty string
+ * Tests whether the value is <b>not</b> <code>null</code> or an empty
string
*
* @param value the value, if its a String it will be tested for text
length as well
Review Comment:
<!-- hermes-bot -->
The `isNotEmpty(String)` overload was touched in this PR (tag change), but
the description still says "or an empty string" — now inconsistent with the
corrected `isNotEmpty(Collection<?>)` and `isNotEmpty(Map<?,?>)` siblings which
were fixed to say "and not an empty collection/map". The `@param` text also
retains copy-pasted wording ("if its a String it will be tested for text length
as well") that is meaningless on a `String`-typed parameter.
```suggestion
* Tests whether the value is <b>not</b> <code>null</code> and
<b>not</b> blank
*
* @param value the value to test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
