gnodet-bot commented on code in PR #29579:
URL: https://github.com/apache/camel/pull/29579#discussion_r4531396694
##########
core/camel-util/src/main/java/org/apache/camel/util/ObjectHelper.java:
##########
@@ -263,7 +263,7 @@ public static boolean isNotEmpty(String value) {
}
/**
- * Tests whether the value is <tt>null</tt> or an an empty collection
+ * Tests whether the value is <code>null</code> or an an empty collection
Review Comment:
💡 **Pre-existing Javadoc issues in `isNotEmpty(Collection<?> value)` — worth
fixing here since the description was already modified:**
1. **Double article:** `"or an an empty collection"` → `"or an empty
collection"`
2. **Wrong description:** says `"Tests whether the value is null or an empty
collection"` but `isNotEmpty` returns `true` when NOT null/empty — the
description should say `"Tests whether the value is not null and not an empty
collection"`
3. **Wrong `@return`:** says `true if empty` but should say `true if not
empty`
##########
core/camel-util/src/main/java/org/apache/camel/util/ObjectHelper.java:
##########
@@ -273,7 +273,7 @@ public static boolean isNotEmpty(Collection<?> value) {
}
/**
- * Tests whether the value is <tt>null</tt> or an an empty map
+ * Tests whether the value is <code>null</code> or an an empty map
Review Comment:
💡 **Pre-existing Javadoc issues in `isNotEmpty(Map<?, ?> value)` — worth
fixing here since the description was already modified:**
1. **Double article:** `"or an an empty map"` → `"or an empty map"`
2. **Wrong description:** says `"Tests whether the value is null or an empty
map"` but `isNotEmpty` returns `true` when NOT null/empty — should say `"Tests
whether the value is not null and not an empty map"`
3. **Wrong `@return`:** says `true if empty` but should say `true if not
empty`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
