ammachado commented on PR #28819:
URL: https://github.com/apache/camel/pull/28819#issuecomment-6727475642
Thanks, all four are in 213e9c56ca0f.
**`@Isolated`.** `DefaultInstrumentationProcessorTimingTest` is now
`@Isolated`, with a Javadoc line saying why, as in `StepHelperTest`.
**Stream caching.** `StreamCachingAdvice` clears the time only when it made
a new cache (`cache != null && cache != body`), as you proposed.
`CamelInternalProcessorAdviceLastNodeEndTest` has the two tests: a
`ByteArrayInputStream` body clears the time, a `String` body keeps it. The
first one fails without the change. The upgrade-guide entry mentions it.
**Loop.** `LoopProcessor` clears the time before each iteration.
`LoopLastNodeEndTest` records the time each iteration's first output sees: `[0,
42, 42]` without the change, `[0, 0, 0]` with it. The upgrade guide now lists
`loop` among the nested cases.
**End-to-end test.** One correction first: a `delay` has no outputs.
`ExpressionNode.getOutputs()` returns an empty list, and `DelayDefinition` is
not an `OutputNode`, so in `from(..).to("log:a").delay(1000).to("log:b")` the
`log:b` node is a sibling of the delay, added to the route. A test built on
that route passed even with the nested-node fix reverted (`mock:b` reported 0
ms). The nested-node fix still matters for `choice`, `filter`,
`idempotentConsumer`, `transacted` and `onException`. I removed `delay` from
those examples in the upgrade guide, the code comment and the PR body.
`ManagedProcessorTimeWithRouteDelayerTest` uses the route `delayer` instead.
It wires a real `DelayerAdvice` ahead of the statistics of each node, with and
without an error handler that can redeliver, and asserts that `mock:b`'s
`MaxProcessingTime` stays well under the delay while the route takes at least
twice the delay. With the clear removed from `DelayerAdvice`, both variants
fail (`mock:b` at about 200 ms).
`camel-management` in full: 600 tests, 1 skipped, 0 failures. The
`camel-core` stream caching, `impl.engine`, loop and delayer tests: 334, 0
failures. `camel-core` was not run in full on this commit.
_Claude Code on behalf of Adriano Machado (@ammachado)_
_This was generated by an AI agent and may contain inaccuracies. Please
verify before relying on it._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
