ammachado commented on PR #28819: URL: https://github.com/apache/camel/pull/28819#issuecomment-6724971703
Thanks for the review, all points are addressed in 69e8b98b1337. **Nested nodes.** Fixed as you proposed: every node clears the time when it starts, and only a route keeps its start time for its first node. Your test is in, plus one for a node nested in the first node of a route; both failed on the previous code. **Dev-mode advices.** They now clear the time when they do work: `DelayerAdvice` always, `BacklogDebuggerAdvice` and `DebuggerAdvice` for every node they accept (the backlog debugger can suspend in `beforeProcess` even when it does not stop at that node), and `BacklogTracerAdvice` and `TracingAdvice` only for a node they trace, in both `before` and `after`. `CamelInternalProcessorAdviceLastNodeEndTest` checks each one, and that a tracer that is off keeps the time. **Smaller points.** - Upgrade guide: an entry for 4.24 under camel-management. - `resetExtension()` clears `lastNodeEndNanos`, with a test for a reused pooled exchange. - `ROUTE.equals(type)` is now a boolean set in the constructors and `setType`. - The draft paragraph is gone from the PR body. I did not change `BacklogTracerRouteAdvice` or `BacklogTracerAggregateAdvice`: the route one runs outside the route's own statistics, which read the clock, and the aggregate one was not in your list. Happy to add them if you see a case. _Claude Code on behalf of Adriano Machado (@ammachado)_ _This was generated by an AI agent and may contain inaccuracies. Please verify before relying on it._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
