Jinal-Sarvaiya commented on code in PR #149:
URL: https://github.com/apache/camel-kit/pull/149#discussion_r4478320476
##########
kit/camel-kit-core/src/main/java/org/apache/camel/kit/ship/controller/ShipNativeWorker.java:
##########
@@ -309,6 +315,10 @@ static void applyProposals(
}
List<ArtifactManifest.DeclaredArtifact> artifacts = new ArrayList<>();
for (String path : List.of(".camel-kit/config.properties", "pom.xml"))
{
+ Path resolved = candidate.resolve(path);
+ if (!Files.exists(resolved, LinkOption.NOFOLLOW_LINKS)) {
+ continue;
Review Comment:
Removed the `Files.exists` / `continue` skip for `config.properties` and
`pom.xml`. Both are required artifacts in the EXECUTE stage — skipping them
produces a manifest missing required declared artifacts, which violates the
schema contract
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
