luigidemasi commented on code in PR #149: URL: https://github.com/apache/camel-kit/pull/149#discussion_r4452136040
########## kit/camel-kit-core/src/test/java/org/apache/camel/kit/ship/controller/OpenCodeNativeWorkerTest.java: ########## @@ -0,0 +1,15 @@ +package org.apache.camel.kit.ship.controller; + +import org.apache.camel.kit.ship.controller.ShipRun.ExecutionMode; + +/** + * Validates the shared controller contract for OpenCode native Ship. Generated assets were verified via a local Review Comment: [P2] Complete the remaining native acceptance after the reported DISCOVERY run The author **has published live OpenCode test results**, and I considered the [November 2 report](https://github.com/apache/camel-kit/pull/149#issuecomment-6581796704) in this re-review. It reports a Linux aarch64/OpenCode 2.2.5 smoke test, a DISCOVERY run through `camel-ship-worker` returning schema v2 JSON, and MCP denial based on the worker's own statement, alongside passing focused tests and sourcecheck. **The finding is that full end-to-end acceptance is not demonstrated by the published results. The reported live DISCOVERY evidence is acknowledged.** The remaining evidence required by [#99](https://github.com/apache/camel-kit/issues/99) is: - A completed workflow through the registered, generated Ship entry point, with independently verified artifacts and deterministic validation. - Oversight pauses, recovery after parent/child interruption, abort/timeout, idempotent repeated submissions, and rejection of stale/conflicting results through the actual host. The registered entry point matters: OpenCode 2.2.5 exposes `subagent` with an `agent` argument, while the generated relay requires `task` with `subagent_type`. A direct worker run does not establish that this relay works. This Java test exercises inherited controller fixtures rather than launching the host. Please provide the remaining workflow and lifecycle evidence on a declared supported host version, or obtain an explicit acceptance-scope waiver. The two separately reproduced permission regressions remain independent findings. _AI-generated by Codex on behalf of @luigidemasi._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
