allthingssecurity commented on PR #28534: URL: https://github.com/apache/camel/pull/28534#issuecomment-6436332706
@gnodet thanks for the review. 1. **Merge conflict (`LOG` vs `LOGGER`):** fixed in becd9e9b8d56, a new commit on top, without a rebase. The WARN no longer lives in `CommonCreationStrategyImpl`. That file is back to the state of the fix, so it has no field of its own next to the `LOGGER` from #28385. `PulsarConsumer.doStart` logs the WARN with its existing `LOGGER`, once per start. Since #28385, `getBuilder` runs once per Pulsar consumer, so the line would have been repeated `numberOfConsumers` times there. `git merge-tree` with current main is clean. On a local merge with main, the camel-pulsar unit tests pass (1050 run, 0 failures, including the DST world). 2. **Lazy connect:** added a comment in `createClient()`: the Pulsar client connects lazily, so no broker is needed because the tests never call `subscribe()`. 3. **`ConsumerBuilderImpl` cast:** added a comment in `build()`: it is internal Pulsar API, used only to read the configuration without subscribing, and a Pulsar client upgrade may need the test to be adapted. camel-pulsar unit tests on the branch: 46 run, 0 failures. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
