allthingssecurity commented on PR #28534: URL: https://github.com/apache/camel/pull/28534#issuecomment-6436332309
@davsclaus thanks, agreed that it should stay visible. Done in two new commits on top: 3cdb89143daf and becd9e9b8d56. The second one moves the WARN out of `CommonCreationStrategyImpl` after a merge conflict with main (see below). I kept the start working and added a WARN rather than failing the start. `PulsarConsumer.doStart` now logs one WARN line before it creates the Pulsar consumers: - in retry mode, when `retryLetterTopic` or `deadLetterTopic` is set without `maxRedeliverCount`. The line says the topics are ignored, that the Pulsar client then uses its default policy (16 redeliveries, then its default retry letter and dead letter topics), and to set `maxRedeliverCount`; - without retry mode, when `deadLetterTopic` is set without `maxRedeliverCount`. The line says the topic is ignored and that without a policy no message goes to a dead letter topic; - without retry mode, when `retryLetterTopic` is set. It is ignored without `enableRetry`, with or without a count, so the line says that. This is a little beyond your suggestion. I added it because the same silent-ignore applies there. It is in `PulsarConsumer` and not in `getBuilder`. Since CAMEL-25869 (#28385, merged), `getBuilder` runs once per Pulsar consumer, so with `numberOfConsumers > 1` the line would have been repeated. Also, the first version added a `LOG` field next to main's new `LOGGER` and conflicted with main. `CommonCreationStrategyImpl` is now as in the fix, and the branch merges cleanly with main. New `PulsarConsumerIgnoredTopicsTest`, 6 tests. It starts routes on a mocked `PulsarClient` and checks the WARN lines with an appender on the `PulsarConsumer` logger: one line in each of the four cases above (including retry mode with only `deadLetterTopic`), and none in the controls (topics with `maxRedeliverCount`, no topics). Without the call in `doStart` the 4 tests that expect a line fail. I also added one sentence to the 4.24 upgrade guide entry. camel-pulsar unit tests: 46 run, 0 failures. I also ran them on a local merge of the branch with current main (not pushed), where the module has the DST world: 1050 run, 0 failures. The formatter and import sort made no changes. I updated the description to match. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
