Croway commented on PR #27958:
URL: https://github.com/apache/camel/pull/27958#issuecomment-6226586675

   Review follow-ups are in 6676883e9f13, one commit on top of the three 
existing ones, and the branch is rebased on main (hence the force push). Rebase 
notes: `ToolRegistry` keeps main's `json(String)` helper from #27982 next to 
this branch's `routeFilter` and `isPlainFileName`, and main's new 
`RuntimeToolsTest` in camel-jbang-core asserted the `id` key for route-dump and 
route-structure, which this branch changes to `filter` on purpose, so those 
three assertions now read `filter`.
   
   - `camel cmd receive` everywhere; `camel.trace.standby` in the history hint 
and on the MCP page.
   - `camel_runtime_receive` takes `limit` (default 1): the first `limit` 
messages of the poll are returned and the rest are counted as `notReturned`.
   - The timeout-text check and `RuntimeHelper.TIMEOUT_PREFIX` are removed, as 
it could not trigger since #27931; the description and the upgrade guide no 
longer present it as a change.
   - The receive file is read from the offset; a failed stop of the receive 
console no longer loses the answer and names the stop command.
   
   On the TUI note: agreed, the AI panel only reads `isReadOnly()` and 
`isCore()`, so the destructive flag on `send_message` changes nothing there; 
that is the MCP hint only.
   
   Tests: whole camel-jbang-mcp module (485), camel-jbang-core 
`RuntimeToolsTest` and `ToolRegistryRuntimeActionsTest`, TUI 
`AiPanelPromptBudgetTest` (no budget change), all passing.
   
   _Claude Code on behalf of Croway_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to