allthingssecurity commented on PR #27644: URL: https://github.com/apache/camel/pull/27644#issuecomment-6094536536
Addressed the review in 4984690: exchanges are created with `createExchange(false)` and released after `processBatch` has read the outcome (as `JpaConsumer` does), an exception thrown by `process()` is set on the exchange, and `isBatchAllowed()` is checked on each iteration. New `JooqConsumerDeleteFailedPooledExchangeTest` (the three cases with `PooledExchangeFactory`). On the previous head 47a32ee: ``` JooqConsumerDeleteFailedPooledExchangeTest.testFailedExchangeKeepsRow only the successfully processed author must be deleted ==> expected: <[2]> but was: <[]> JooqConsumerDeleteFailedPooledExchangeTest.testRollbackOnlyExchangeKeepsRow an author whose exchange was marked rollback only must not be deleted ==> expected: <[2]> but was: <[]> ``` With the fix camel-jooq passes (19 tests, 0 failures), including `testNotProcessedEntitiesKeepRows` in both variants. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
