gnodet-bot commented on code in PR #26906:
URL: https://github.com/apache/camel/pull/26906#discussion_r4106835555


##########
tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/UpdateReadmeMojo.java:
##########
@@ -539,7 +539,9 @@ private boolean updateHeader(
             newLines.add(":shortname: " + shortName);
 
             if (model instanceof ArtifactModel<?>) {

Review Comment:
   👍 Extracting the `ArtifactModel<?>` to a local variable before accessing 
both `getGroupId()` and `getArtifactId()` is cleaner than the previous inline 
cast. The logic is correct — `getGroupId()` is populated from the generated 
JSON metadata (`component.properties`) during the build.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to