gnodet-bot commented on code in PR #26857:
URL: https://github.com/apache/camel/pull/26857#discussion_r4094275826
##########
components/camel-aws/camel-aws2-s3/pom.xml:
##########
@@ -33,6 +33,12 @@
<description>Consume files and upload files through AWS S3
Service</description>
<properties>
+ <auth-version>2.55.1</auth-version>
+ <aws-core-version>2.55.1</aws-core-version>
+ <http-client-spi-version>2.55.1</http-client-spi-version>
+ <regions-version>2.55.1</regions-version>
+ <sdk-core-version>2.55.1</sdk-core-version>
+ <utils-version>2.55.1</utils-version>
Review Comment:
⚠️ **Version property duplication — same issue as the Spring fix in
86c97a50.**
The parent POM already defines `${aws-java-sdk2-version}=2.55.1`, which
covers all these sub-artifacts (`auth`, `sdk-core`, `aws-core`, `regions`,
`http-client-spi`, `utils`). Declaring redundant local properties pins them
independently: if the parent bumps `aws-java-sdk2-version`, these local
overrides silently stay at the old version, causing version skew across the SDK.
```suggestion
</properties>
```
Drop all 6 local properties and switch the `<version>` references in
`<dependencyManagement>` to `${aws-java-sdk2-version}`. Same fix needed in
every AWS module that follows this pattern (~30 modules).
##########
components/camel-kafka/pom.xml:
##########
@@ -55,18 +55,37 @@
</exclusion>
</exclusions>
</dependency>
- <dependency>
- <groupId>at.yawk.lz4</groupId>
- <artifactId>lz4-java</artifactId>
- <version>${lz4-java-version}</version>
- </dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>
<!-- test -->
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-management-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-util</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-util-json</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-core</artifactId>
Review Comment:
⚠️ **Compile deps placed in the test section.**
`camel-api`, `camel-management-api`, `camel-util`, `camel-util-json`,
`slf4j-api`, and `jackson-core` are compile-scope dependencies (no
`<scope>test</scope>`), but they are placed after the `<!-- test -->` marker.
In this file — and all 84 others following the same pattern — every existing
dep after that marker has an explicit `<scope>test</scope>`. The six new deps
lack it, making them look test-only to the reader while Maven treats them as
compile-scope.
These should move to the compile section above the `<!-- test -->` comment.
Functionally Maven is fine, but the misleading placement will cause confusion
when someone later tries to understand what camel-kafka exposes at runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
