gnodet commented on code in PR #26857:
URL: https://github.com/apache/camel/pull/26857#discussion_r4094450118
##########
components/camel-aws/camel-aws2-s3/pom.xml:
##########
@@ -33,6 +33,12 @@
<description>Consume files and upload files through AWS S3
Service</description>
<properties>
+ <auth-version>2.55.1</auth-version>
+ <aws-core-version>2.55.1</aws-core-version>
+ <http-client-spi-version>2.55.1</http-client-spi-version>
+ <regions-version>2.55.1</regions-version>
+ <sdk-core-version>2.55.1</sdk-core-version>
+ <utils-version>2.55.1</utils-version>
Review Comment:
Fixed in 0ed513ef4ef07b92ea85337083ec7c5d0e50e599 — dropped all 6 local AWS
SDK version properties and replaced `${auth-version}`, `${aws-core-version}`,
`${http-client-spi-version}`, `${regions-version}`, `${sdk-core-version}`,
`${utils-version}` with `${aws-java-sdk2-version}` across all 35 affected AWS
component POMs.
##########
components/camel-kafka/pom.xml:
##########
@@ -55,18 +55,37 @@
</exclusion>
</exclusions>
</dependency>
- <dependency>
- <groupId>at.yawk.lz4</groupId>
- <artifactId>lz4-java</artifactId>
- <version>${lz4-java-version}</version>
- </dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>
<!-- test -->
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-management-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-util</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-util-json</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-core</artifactId>
Review Comment:
Fixed in 0ed513ef4ef07b92ea85337083ec7c5d0e50e599 — moved all compile-scope
deps (camel-api, camel-management-api, camel-util, camel-util-json, slf4j-api,
jackson-core, and others) above the `<!-- test -->` / `<!-- for testing -->`
markers across 87 component POMs.
##########
components/camel-avro-rpc/camel-avro-rpc-spi/pom.xml:
##########
@@ -38,9 +38,9 @@
<dependencies>
<dependency>
<groupId>org.apache.avro</groupId>
- <artifactId>avro-ipc-jetty</artifactId>
- <version>${avro-ipc-jetty-version}</version>
+ <artifactId>avro-ipc</artifactId>
+ <version>1.12.2</version>
Review Comment:
Fixed in 0ed513ef4ef07b92ea85337083ec7c5d0e50e599 — using `${avro-version}`
instead of the hardcoded literal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
