allthingssecurity commented on PR #26795: URL: https://github.com/apache/camel/pull/26795#issuecomment-5811054195
@oscerd thanks. Agreed on stacking #26795 and #26797. One nuance on letting `suspendOnly` drive both: the flag says what the shutdown strategy is doing *now* (suspending versus stopping), while #26797 is about a *stop* of a consumer that is *already* suspended (for example by a `RoutePolicy` through `ServiceHelper.suspendService(consumer)`). In that case `suspendOnly` is `false`, so the consumer still needs its own `isSuspending()/isSuspended()` check to skip the wait. In a combined `getPendingExchangesSize(boolean suspendOnly)`: - `suspendOnly` → don't purge (this PR); - consumer already suspended/suspending → report 0, so the stop doesn't wait (#26797); - otherwise → purge if `purgeWhenStopping`, and return the queue size. Whichever lands second, I'll rebase it into that shape. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
