allthingssecurity opened a new pull request, #26795: URL: https://github.com/apache/camel/pull/26795
# Description [CAMEL-24949](https://issues.apache.org/jira/browse/CAMEL-24949) Suspending a route (`suspendRoute`, `camelContext.suspend()`, JMX) with `purgeWhenStopping=true` discarded all queued messages: 4 of 5 were lost across suspend and resume. `DefaultShutdownStrategy` uses the same wait loop for suspend and stop, and `SedaConsumer.getPendingExchangesSize()` purged whenever `purgeWhenStopping` was set, because it can't tell a suspend from a stop. This change: - camel-api: a new default method `ShutdownAware.getPendingExchangesSize(boolean suspendOnly)` that delegates to `getPendingExchangesSize()`, so existing implementations are unaffected. - `DefaultShutdownStrategy` passes its `suspendOnly` flag. - `SedaConsumer` purges only on stop. - The upgrade guide notes the change. The SPI addition is the one design point for reviewers. The alternative, calling `prepareShutdown(true, false)` before the loop, would change the call sequence for every `ShutdownAware` consumer. Tests: new `SedaPurgeWhenStoppingSuspendTest`. Without the fix, 1 message is delivered instead of 5. Seda and shutdown suites: 172 tests, 0 failures (2 pre-existing skips). Found with a TLA+ model of SEDA suspend/stop through DefaultShutdownStrategy, then reproduced against the real classes. # Target - [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). # Apache Camel coding standards and style - [x] I checked that each commit in the pull request has a meaningful subject line and body. - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. (I built and tested the affected modules, including the formatter and import-sort plugins. I did not run the full root build.) # AI-assisted contributions - [x] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used. This PR was prepared with Claude Code (Claude Opus 5.5). The commit carries a `Co-Authored-By` trailer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
